Skip to content

BFS enhancement with collections.deque (fix: #12857) #12882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

BFS enhancement with collections.deque (fix: #12857) #12882

wants to merge 2 commits into from

Conversation

riokuma
Copy link

@riokuma riokuma commented Aug 4, 2025

Describe your change:

Enhancement for breadth_first_search_shortest_path_2 with Collections.deque for the issue I raised (fix: #12857)

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a [closing keyword]: Performance Enhancement: Replace list with collections.deque in graph algorithms #12857 "Fixes Performance Enhancement: Replace list with collections.deque in graph algorithms #12857".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Aug 4, 2025
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mindaugl mindaugl mindaugl approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performance Enhancement: Replace list with collections.deque in graph algorithms
2 participants
@riokuma @mindaugl